created toggle with process.env.VUE_APP_ALLOW_LOCAL_SW to allow local… #3329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… service worker development
|
Never mind this - variables on process.env are strings, so boolean check doesn't work. Any advice for what would be a good globally injected variable to use when implementing such a toggle? |
|
I changed the toggle to specifically check for the string 'true'. This works of course, but would be glad to change it if a better option is suggested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building PWA's with complex functionalities and interactions, it may be desirable to have a functioning service worker in development mode. This branch has a toggle in the shape of VUE_APP_ALLOW_LOCAL_SW that, when set to true, allows the developer to have the service worker under development installed on the client while running the development server.