Skip to content

docs(proxy): add warning when proxy set as string (fix #3308) #3320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 10, 2019
Merged

docs(proxy): add warning when proxy set as string (fix #3308) #3320

merged 1 commit into from
Jul 10, 2019

Conversation

lbogdan
Copy link
Contributor

@lbogdan lbogdan commented Jan 17, 2019

Fixes #3308 , see that for details.

@lbogdan
Copy link
Contributor Author

lbogdan commented Jan 17, 2019

Comments:

  • better wording?
  • should we recommend Postman? I added it because I felt "API tool" alone might not be very clear.
  • should we instead recommend to make a request using axios / fetch?

@NataliaTepluhina
Copy link
Member

@lbogdan (better late than never): I think the wording is fine and I am also fine with Postman :)

@NataliaTepluhina NataliaTepluhina merged commit 9be9b6c into vuejs:dev Jul 10, 2019
@vue-bot
Copy link

vue-bot commented Jul 10, 2019

Hey @lbogdan, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NataliaTepluhina NataliaTepluhina NataliaTepluhina approved these changes

Assignees
No one assigned
Labels
PR: Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[docs] Setting devServer.proxy to a string value can be confusing
4 participants
@lbogdan @NataliaTepluhina @vue-bot @haoqunjiang