Fix Template files for main.js and router when not using a compiler #2828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't use arrow function in main.js when not using babel nor typescript.
use normal function instead of arrow function in router.js when neither babel nor typescript are used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, both
main.jsandrouter.jstemplates contain arrow functions.When a user chooses not to select babel or typescript during project creation, the generated code will fail in browsers that don't support arrow functions.
Since we aim to be compatible with IE 11 out of the box, I added conditionals to the templates for these files to use a normal function instead when neither babel nor typescript plugins are detected.