Fix: revert addition of cypress-webpack-preprocessor #2672
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This actually broke tests and was only added for convenience (#2465)
codeams
approved these changes
Oct 6, 2018
haoqunjiang
added a commit
that referenced
this pull request
Oct 7, 2018
Some issues only happens in GUI mode (#2672), so we need to manually identify these issues during development.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I was trying to fix #2667 I found that cypress tests were not working anymore for the default
--mode production, but they do work for--mode development.Some testing found that it is related to the addition of
cypress-webpack-preprocessorintroduced in bd32daa to solve #2465Removing that makes tests work again.
I tried to find out what about the production config breaks the preprocessor, but was unsuccessful.
Since it was only introduced to provide a convenience feature (
@/alias path support in cyprss test files) I submit this PR to revert the feature until we have found a proper fix for the problem.Maybe we just have to remove some plugin from the production config that we load into the preprocessor, but so fa I haven't figured out which one it is.