fix: revert default symlinks setting
#2409
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haoqunjiang
changed the title
symlinks to truesymlinks setting
haoqunjiang
force-pushed
the
symlinks
branch
2 times, most recently
from
20730ba to
937204a
Compare
Currently in Vue CLI we set the default `symlinks` config to `false`. This setting is counterintuitive, and inconsitent with webpack's default configuration, per https://webpack.js.org/configuration/resolve/#resolve-symlinks The change of default `symlinks` value is introduced by vuejs@5b4df14 It is most likely a duplicate of vuejs@145492b Since several third-party npm clients uses symlinks to speed up installation (e.g. cnpm, pnpm...), that change breaks webpack HMR for their users. See vuejs#1559, vuejs#2195, vuejs#2284 This commit also fixes vuejs#1609
haoqunjiang
force-pushed
the
symlinks
branch
from
937204a to
a783d20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in Vue CLI we set the default
symlinksconfig tofalse.This setting is counterintuitive, and inconsitent with webpack's default
configuration, per https://webpack.js.org/configuration/resolve/#resolve-symlinks
The change of default
symlinksvalue is introduced by 5b4df14It is most likely a duplicate of 145492b
Since several third-party npm clients uses symlinks to speed up installation
(e.g. cnpm, pnpm...), that change breaks webpack HMR for their users.
See #1559, #2195, #2284
This commit also fixes #1609