Skip to content

fix: revert named-chunks nameResolver algorithm #2324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 4, 2018
Merged

fix: revert named-chunks nameResolver algorithm #2324

merged 2 commits into from
Sep 4, 2018

Conversation

haoqunjiang
Copy link
Member

closes #1996

  1. Hash collision is normal in multi page mode (they might share a index.html chunk).
  2. Otherwise, chunks contain only 1 module in most cases, making the aesthetics improvement unnecessary.

@haoqunjiang haoqunjiang requested a review from yyx990803 August 22, 2018 14:39
@haoqunjiang haoqunjiang merged commit 3933187 into vuejs:dev Sep 4, 2018
@haoqunjiang haoqunjiang mentioned this pull request Jan 18, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yyx990803 yyx990803 Awaiting requested review from yyx990803

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

vue-cli will remain in the building state without displaying the compilation results when you have more than 5 page entries(in my computer)
1 participant
@haoqunjiang