Skip to content

fix(cli-ui): apollo server awaiting for running e2e tests #2323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Kocal
Copy link
Contributor

@Kocal Kocal commented Aug 22, 2018

Close #2308.

To run e2e tests after Apollo server is up, we use start-server-and-test that internally use wait-on.

For http(s) resources wait-on will check that the requests are returning 2XX (success) to HEAD or GET requests (after following any redirects).

~ wait-on documentation

  • http://localhost:4040 returns a 404, so it won't works
  • http://localhost:4040/graphql returns a 405 because wait-on use a HEAD request
  • http-get://localhost:4040/graphql for forcing a GET request, but it returns a 400 because I didn't provided any query parameter.
  • http-get://localhost:4040/graphql?query={cwd} works fine

capture d ecran de 2018-08-22 15-49-15

@Kocal
Copy link
Contributor Author

Kocal commented Oct 31, 2018

Closing because #2806 fixed it, thank you @Akryum

@Kocal Kocal closed this Oct 31, 2018
@Kocal Kocal deleted the fix/2308 branch January 23, 2019 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant