Skip to content

component.md : Component Naming Conventions better consistency #903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 19, 2017
Merged

component.md : Component Naming Conventions better consistency #903

merged 6 commits into from
May 19, 2017

Conversation

MachinisteWeb
Copy link
Contributor

@MachinisteWeb MachinisteWeb commented May 11, 2017

Hi everybody. You will find in this PR about Component Naming Conventions Guide part 4 points I propose to update:

  1. TitleCase
    There is one « Title case » term so to follow all others I change it into « TitleCase »

  2. Case vs Cased
    In first part and old second part version you used kebab-cased-component with letter « d ».
    In second part you not use « d ». I think it's a better choice to kept consitency accross naming

  3. Opened and Closed tag in exemple
    I know it's possible to say « there is too verbose » but you have not already explain that is possible to use self-closed format <my-component /> when you use following example

    <kebab-cased-component />
    
    <camel-cased-component />
    <camelCasedComponent />
    
    <title-cased-component />
    <titleCasedComponent />
    <TitleCasedComponent />

    So there is two way:

    1. Use full tag declaration (in this PR)
    2. Explain more sooner that is possible to use self closed way (not in this PR)
  4. Space
    I have add a space in self-closed format to respect what you have done in part 3.

Signed-off-by: Bruno Lesieur <bruno.lesieur@gmail.com>
Signed-off-by: Bruno Lesieur <bruno.lesieur@gmail.com>
Signed-off-by: Bruno Lesieur <bruno.lesieur@gmail.com>
@MachinisteWeb MachinisteWeb changed the title Component.md - Component Naming Conventions better consistency component.md : Component Naming Conventions better consistency May 15, 2017
@chrisvfritz
Copy link
Contributor

Thanks! I made one tiny change to remove the space you added before the end of the self-closing component, but otherwise I like the changes. 🙂 Those previous spaces were before the end were something I missed from another contributor, but I really appreciate your attention to detail!

@chrisvfritz chrisvfritz merged commit a5b1643 into vuejs:master May 19, 2017
@MachinisteWeb MachinisteWeb deleted the master branch July 11, 2017 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants