Skip to content

Update index.md #808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 8, 2017
Merged

Update index.md #808

merged 1 commit into from
Mar 8, 2017

Conversation

zrw354
Copy link
Contributor

@zrw354 zrw354 commented Mar 8, 2017

To make the documents more user-friendly, we need to break long lines in sample HTML/JavaScript code into short lines to avoid horizontal scrollbars caused by limited column width

Break long lines in sample HTML code into short lines to avoid a horizontal scrollbar caused by limited column width
Copy link
Member

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR!
Why did you fix this?
Visibility?

@kazupon
Copy link
Member

kazupon commented Mar 8, 2017

ah, sorry, I saw the your comment.
LGTM.

@kazupon kazupon requested a review from chrisvfritz March 8, 2017 05:25
@zrw354
Copy link
Contributor Author

zrw354 commented Mar 8, 2017

@kazupon Thanks for the quick response! In this case document users have to use a horizontal scrollbar to view the hidden part of only one long line, but if we don't pay attention to source code line length sometimes many lines could be hidden, causing significant usability issues. You guys have done a great job in making Vue user-friendly. Let's keep the momentum going!

@kazupon kazupon merged commit d77cdc4 into vuejs:master Mar 8, 2017
@zrw354 zrw354 deleted the patch-1 branch March 8, 2017 16:38
kazupon pushed a commit to kazupon/vuejs.org that referenced this pull request Oct 1, 2017
Break long lines in sample HTML code into short lines to avoid a horizontal scrollbar caused by limited column width
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants