Skip to content

Fix typo: 'is' => 'id' #757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 10, 2017
Merged

Fix typo: 'is' => 'id' #757

merged 1 commit into from
Feb 10, 2017

Conversation

jipe
Copy link
Contributor

@jipe jipe commented Feb 10, 2017

No description provided.

@kazupon kazupon merged commit 6a63bed into vuejs:master Feb 10, 2017
@Alex-Sokolov
Copy link
Contributor

But is was correct!
It's not multiple li-items with identical id
It is a component which described below and named Vue.component('todo-item',...

@znck
Copy link
Member

znck commented Feb 10, 2017

Oh! My bad. Component is defined in later part. (Was not visible in snippet)

Nice catch @Alex-Sokolov 👍

/ping @kazupon Can you revert this (accept #758)?

@jipe
Copy link
Contributor Author

jipe commented Feb 11, 2017

Sorry guys, I jumped the gun. When reading on through the components section, this all made sense - and of course I should have thought it through that you were not trying to create multiple elements with the same id :-). Keep up the good work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants