Skip to content

remove wrong statement about el: option. (fix #499) #504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 13, 2016

Conversation

LinusBorg
Copy link
Member

@LinusBorg LinusBorg commented Oct 13, 2016

fixing #499

Docs state here:

The el option also requires a function value when used in a component instance, for exactly the same reason.

As the el option can only be used during instance creation in 2.0, this seems to be no longer the case, right?

The 2.0 API docs for the el: option also say that it can only be String | HTML Element

@LinusBorg LinusBorg changed the title remove wrong statement about el: option. remove wrong statement about el: option. (fix #499) Oct 13, 2016
@chrisvfritz chrisvfritz merged commit 5c2dad7 into master Oct 13, 2016
@LinusBorg LinusBorg deleted the el_cant_be_function_anymore branch October 13, 2016 10:30
dingyiming added a commit to volksbright/document-standard-vue that referenced this pull request Oct 14, 2016
* master: (38 commits)
  Fix a typing error. (vuejs#507)
  add source links to api entries
  remove warning about the migration helper not catching vue-router deprecations yet
  fix content overlapping sidebar on blog pages, fixes vuejs#431
  remove wrong statement about el: option. (vuejs#504)
  fix scoping error loadingRouteData example
  add arbitrary route properties to vue-router migration guide
  fix subRoutes case typo
  fix description for router.go deprecation
  added header background header transition and made it appear on slightly smaller screens to accomodate macbook air 11-inch
  make mobile bar box shadow more subtle
  make header mostly transparent on large screens to increase vertical content space
  make header box shadow more subtle
  extend sidebar scroll area to left wall
  Fix variable reference in $mount sample code. (vuejs#501)
  Updated firebase example inputs (vuejs#502)
  fix filter function examples, fixes vuejs#503
  add vuex migration guide
  update vue alias instructions
  fix sidebar not auto-scrolling on api page
  ...

# Conflicts:
#	src/api/index.md
#	src/examples/firebase.md
#	src/guide/components.md
#	src/guide/events.md
#	src/guide/instance.md
#	src/guide/migration-vue-router.md
#	src/guide/migration.md
#	src/guide/routing.md
#	src/guide/single-file-components.md
#	src/guide/transitions.md
#	themes/vue/layout/partials/ad.ejs
#	themes/vue/source/css/page.styl
Peter-WF pushed a commit to Peter-WF/vuefe.github.io that referenced this pull request Nov 18, 2016
Peter-WF pushed a commit to Peter-WF/vuefe.github.io that referenced this pull request Nov 18, 2016
* master: (38 commits)
  Fix a typing error. (vuejs#507)
  add source links to api entries
  remove warning about the migration helper not catching vue-router deprecations yet
  fix content overlapping sidebar on blog pages, fixes vuejs#431
  remove wrong statement about el: option. (vuejs#504)
  fix scoping error loadingRouteData example
  add arbitrary route properties to vue-router migration guide
  fix subRoutes case typo
  fix description for router.go deprecation
  added header background header transition and made it appear on slightly smaller screens to accomodate macbook air 11-inch
  make mobile bar box shadow more subtle
  make header mostly transparent on large screens to increase vertical content space
  make header box shadow more subtle
  extend sidebar scroll area to left wall
  Fix variable reference in $mount sample code. (vuejs#501)
  Updated firebase example inputs (vuejs#502)
  fix filter function examples, fixes vuejs#503
  add vuex migration guide
  update vue alias instructions
  fix sidebar not auto-scrolling on api page
  ...

# Conflicts:
#	src/api/index.md
#	src/examples/firebase.md
#	src/guide/components.md
#	src/guide/events.md
#	src/guide/instance.md
#	src/guide/migration-vue-router.md
#	src/guide/migration.md
#	src/guide/routing.md
#	src/guide/single-file-components.md
#	src/guide/transitions.md
#	themes/vue/layout/partials/ad.ejs
#	themes/vue/source/css/page.styl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants