set the background-color to white #452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set the background-color to white so that users whom changed the *default* background-color of their browser (ie. dark theme) can still see the website has intended by the designer.
dingyiming
added a commit
to volksbright/document-standard-vue
that referenced
this pull request
Oct 4, 2016
* master: Revert "Master" (vuejs#462) Master (vuejs#460) Update link to Karma (vuejs#458) Explicitly note on `events` opt deprecation (fixes vuejs#436) (vuejs#453) remove wording about not including a benchmark from the react team Set the background-color to white. (vuejs#452) fix capitalizion typo in migration guide add literal modifier for directives to migration guide fix typo in interpolation within attributes in migration guide update dynamic binding example in guide intro add named slot to render function guide add warnings about using arrow functions on instance properties (vuejs#448) fix links to single-file components - fixes vuejs#446 add note about two-way directives, linking to two-way filters example update two-filters example in migration guide Same word used multiple times in a sentence (vuejs#444) improve $data instance property API docs (vuejs#445) # Conflicts: # src/guide/index.md # src/guide/installation.md # src/guide/instance.md # src/guide/render-function.md # src/guide/unit-testing.md
Peter-WF
pushed a commit
to Peter-WF/vuefe.github.io
that referenced
this pull request
Nov 18, 2016
Set the background-color to white so that users whom changed the *default* background-color of their browser (ie. dark theme) can still see the website has intended by the designer.
Peter-WF
pushed a commit
to Peter-WF/vuefe.github.io
that referenced
this pull request
Nov 18, 2016
* master: Revert "Master" (vuejs#462) Master (vuejs#460) Update link to Karma (vuejs#458) Explicitly note on `events` opt deprecation (fixes vuejs#436) (vuejs#453) remove wording about not including a benchmark from the react team Set the background-color to white. (vuejs#452) fix capitalizion typo in migration guide add literal modifier for directives to migration guide fix typo in interpolation within attributes in migration guide update dynamic binding example in guide intro add named slot to render function guide add warnings about using arrow functions on instance properties (vuejs#448) fix links to single-file components - fixes vuejs#446 add note about two-way directives, linking to two-way filters example update two-filters example in migration guide Same word used multiple times in a sentence (vuejs#444) improve $data instance property API docs (vuejs#445) # Conflicts: # src/guide/index.md # src/guide/installation.md # src/guide/instance.md # src/guide/render-function.md # src/guide/unit-testing.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the background-color to white so that users whom changed the default background-color of their browser (ie. dark theme) can still see the website has intended by the designer.
For instance, when setting the default background-color to a dark themed one in Firefox, the website looks like this :
This pull request just set the css
background-colorproperty towhite, so that the user default background-color is not used.