vm.$slots documentation improvement #419
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@LinusBorg - here is my suggestion. Thanks a lot to @kazupon who laid the foundations for this suggestion. |
LinusBorg
reviewed
Sep 26, 2016
| @@ -902,42 +902,38 @@ type: api | |||
|
|
|||
| - **Details:** | |||
|
|
|||
| A hash of VNode children of component that should resolve with slot. VNode children resolved with Single Slot are stored as the `default` key. VNode children resolve with Named Slot are stored as the key that specified with `slot` attribute. those VNode children are stored an Array. | |||
| An object that holds virtual nodes containing parent contents used for content distribution (transclusion) inside [slots](/guide/components.html#Content-Distribution-with-Slots). The `default` property contains [single slot](/guide/components.html#Single-Slot) contents. Each [named slot](/guide/components.html#Named-Slots) has its own corresponding property, with the same name of the slot. | |||
There was a problem hiding this comment.
May be because I'm not a native speaker, but I had to read the beginning twice. Maybe this is clearer:
"An object that holds virtual nodes which contain parent contents.."
There was a problem hiding this comment.
Ok. Pushed a commit with the change.
But I've made a mistake in the commit message... should I create another PR? (With a single commit and correct message.) Or just let it go?
There was a problem hiding this comment.
@jbruni No need to create another PR - we're going to squash before we merge anyway. I have a couple other changes I'd like to make, but I'll just push up those commits on your branch and then merge. 😃 👍
dingyiming
added a commit
to volksbright/document-standard-vue
that referenced
this pull request
Sep 28, 2016
vm.$slots documentation improvement (vuejs#419)
dingyiming
added a commit
to volksbright/document-standard-vue
that referenced
this pull request
Sep 30, 2016
* 2.0: (113 commits) fix typos in guide introduction update version select update deploy URL and CNAME update example fiddles add vue-router migration guide improve Vue.extend API docs (vuejs#422) tweak index fix support page mobile sidebar tweak mobile update runtime build info tweak position responsive css redesign homepage 2.0.0-rc.8 update makefile update src links Update index.md (vuejs#421) vm.$slots documentation improvement (vuejs#419) Minor grammar / typo change (vuejs#417) add note about lack of async loading in browserify ...
kazupon
pushed a commit
to kazupon/vuejs.org
that referenced
this pull request
Oct 2, 2016
* vm.$slots documentation improvement * vm.$slots doc fix: 'Render Function' instead of 'Render Functions' * $vm.slots - improved initial sentence * additional tweaks to vm. api entry
Peter-WF
pushed a commit
to Peter-WF/vuefe.github.io
that referenced
this pull request
Nov 18, 2016
* vm.$slots documentation improvement * vm.$slots doc fix: 'Render Function' instead of 'Render Functions' * $vm.slots - improved initial sentence * additional tweaks to vm. api entry
Peter-WF
pushed a commit
to Peter-WF/vuefe.github.io
that referenced
this pull request
Nov 18, 2016
vm.$slots documentation improvement (vuejs#419)
Peter-WF
pushed a commit
to Peter-WF/vuefe.github.io
that referenced
this pull request
Nov 18, 2016
* 2.0: (113 commits) fix typos in guide introduction update version select update deploy URL and CNAME update example fiddles add vue-router migration guide improve Vue.extend API docs (vuejs#422) tweak index fix support page mobile sidebar tweak mobile update runtime build info tweak position responsive css redesign homepage 2.0.0-rc.8 update makefile update src links Update index.md (vuejs#421) vm.$slots documentation improvement (vuejs#419) Minor grammar / typo change (vuejs#417) add note about lack of async loading in browserify ...
kazupon
pushed a commit
to kazupon/vuejs.org
that referenced
this pull request
Nov 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.