Skip to content

add $slots property to API docs #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 25, 2016
Merged

add $slots property to API docs #415

merged 2 commits into from
Sep 25, 2016

Conversation

kazupon
Copy link
Member

@kazupon kazupon commented Sep 25, 2016

I realized that $slots property is nothing in guide/api/index.md, when I found that dead link in render function.

@chrisvfritz chrisvfritz merged commit e195a59 into vuejs:2.0 Sep 25, 2016
@kazupon kazupon deleted the improve/api branch September 25, 2016 07:58
@kazupon
Copy link
Member Author

kazupon commented Sep 25, 2016

@chrisvfritz thanks!

@chrisvfritz
Copy link
Contributor

@kazupon Thanks for catching it!

@jbruni
Copy link
Contributor

jbruni commented Sep 26, 2016

Great! Just stumbled upon it. Cool that it has already been resolved.

@jbruni
Copy link
Contributor

jbruni commented Sep 26, 2016

Hmmm... the explanation and code samples seem confusing to me.

@kazupon
Copy link
Member Author

kazupon commented Sep 26, 2016

sorry, my poor english ... 😞

@LinusBorg
Copy link
Member

LinusBorg commented Sep 26, 2016

@jbruni Have you read the sections linked under the example?

The content of $slots can only be understood (and be of any use zo you) to you when you use render functions - in which case you will have to understand what vNodes are, which is explained in the linked guide sections ..

@jbruni
Copy link
Contributor

jbruni commented Sep 26, 2016

@LinusBorg - Yes, I do understand the context, in ttheory and practice. The text could be much simpler, and the code (only perceived now) has a little error (reference to "slot2" and "slot1"), and in my opinion the code does not help clarifying the contents. I'll see if I can quickly write and send a suggestion as PR.

kazupon added a commit to kazupon/vuejs.org that referenced this pull request Oct 2, 2016
* add $slots property to API docs

* fix $slots reference
Peter-WF referenced this pull request in Peter-WF/vuefe.github.io Nov 18, 2016
* add $slots property to API docs

* fix $slots reference
kazupon pushed a commit to kazupon/vuejs.org that referenced this pull request Nov 24, 2017
* Recommend return type annotation (vuejs#1239)

* Recommend return type annotation

* make explanation clear, thank @DanielRosenwasser

* translate

* update date
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants