Remove style guide recommendation on global base components #2949
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now official Vue Style Guide suggests you use global components when you deal with base components. This can lead to confusion with new developers coming to a project, IDE assistance and testing. This PR removes this recommendation so it's always obvious how components are imported.
✅ Deploy Preview for optimistic-kilby-a8719c ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
NataliaTepluhina
approved these changes
Apr 28, 2022
CyberAP
added a commit
to CyberAP/ru.vuejs.org
that referenced
this pull request
Apr 28, 2022
This is a follow-up on vuejs/v2.vuejs.org#2949 to make translation in sync with English version.
Alex-Sokolov
pushed a commit
to translation-gang/ru.vuejs.org
that referenced
this pull request
Apr 30, 2022
This is a follow-up on vuejs/v2.vuejs.org#2949 to make translation in sync with English version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now official Vue Style Guide suggests you use global components when you deal with base components. This can lead to confusion with new developers coming to a project, IDE assistance and testing. This PR removes this recommendation so it's always obvious how components are imported.
Note
This repository is for Vue 1.x and 2.x only. Issues and pull requests related to 3.x are managed in the v3 doc repo: https://github.com/vuejs/docs-next.