Skip to content

Fix broken link to repo explaining Instance names #2808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2021

Conversation

AustinWoetzel
Copy link
Contributor

@AustinWoetzel AustinWoetzel commented Apr 22, 2021

There is a link that is supposed to provide more detail on how data can be "overwritten" in an Instance when you do not use a $ in front of the name. The repo that the link points to has been updated and the path is no longer valid. I replaced it with what I think should be the new path.

Note: the repo link is in reference to a You-Dont-Know-JS (book series). The change in file path in that repo came because they are working on a 2nd edition. The 2nd edition is not released and does not have any info on Instance names. I referenced the archived 1st edition. It is possible that by the time this PR is processed, the 2nd edition will be released and the link may need to be changed to a file path in the 2nd edition.

Copy link
Member

@NataliaTepluhina NataliaTepluhina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix! 👍🏻

@NataliaTepluhina NataliaTepluhina merged commit 7f60df0 into vuejs:master Apr 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants