chore: use SVG logo where applicable #2787
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phanan
commented
Mar 17, 2021
| @@ -21,7 +21,7 @@ | |||
| <meta property="og:type" content="article"> | |||
| <meta property="og:title" content="<%- page.title ? page.title + ' — ' : '' %>Vue.js"> | |||
| <meta property="og:description" content="<%- theme.site_description %>"> | |||
| <meta property="og:image" content="https://<%- theme.root_domain %>/<%- url_for("/images/logo.png") %>"> | |||
| <meta property="og:image" content="https://<%- theme.root_domain %>/images/logo.png"> | |||
There was a problem hiding this comment.
It's quite lame that OG protocol doesn't support SVG but I'm taking this opportunity to make this consistent with the twitter:image meta tag declaration.
bencodezen
approved these changes
Mar 30, 2021
|
Oops can't believe I totally forgot about this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've just realized that we're using a PNG logo everywhere when a much smaller (195B gzipped vs 3KB) SVG can do just fine. This PR does just that: replace the PNG version with SVG where applicable.
If everyone is on board, I'll port this over to v3 naturally.