Skip to content

fix: update unit test code examples with Vue Test Utils #2468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 6, 2020
Merged

fix: update unit test code examples with Vue Test Utils #2468

merged 3 commits into from
Feb 6, 2020

Conversation

sarahdayan
Copy link
Contributor

This PR updates the unit testing code examples using Vue Test Utils.

Since this is the official Vue testing library, and it has new maintainers, this is probably a better experience for users to have an example that matches what they'll learn afterward on the Vue Test Utils documentation.

fix #931

Copy link
Member

@NataliaTepluhina NataliaTepluhina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sarahdayan thank you for fixing this example to be more up-to-date! I've left one minor nitpick 😅

@sarahdayan
Copy link
Contributor Author

@NataliaTepluhina I've changed vm to wrapper to avoid redundancy (vm.vm -> wrapper.vm).

Copy link
Member

@NataliaTepluhina NataliaTepluhina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sarahdayan thank you for the prompt fixes! 🤗
Looks good to me now 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unit test example needs a dom element
2 participants