Moving external example code to the examples folder #2452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Example code from https://jsfiddle.net/09jvu65m/
Once merged, the link https://codesandbox.io/s/github/vuejs/vuejs.org/tree/master/src/v2/examples/vue-20-dynamic-components will work. For testing, use https://codesandbox.io/s/github/garethx/vuejs.org/tree/master/src/v2/examples/vue-20-dynamic-components
Once merged, the link https://codesandbox.io/s/github/vuejs/vuejs.org/tree/master/src/v2/examples/vue-20-priority-d-rules-unintended-consequences will work. For testing, use https://codesandbox.io/s/github/garethx/vuejs.org/tree/master/src/v2/examples/vue-20-priority-d-rules-unintended-consequences Likewise with the app referenced in the explanation text https://codesandbox.io/s/github/vuejs/vuejs.org/tree/master/src/v2/examples/vue-20-priority-d-rules-correct-example / https://codesandbox.io/s/github/garethx/vuejs.org/tree/master/src/v2/examples/vue-20-priority-d-rules-correct-example
Adding package.json required for import
|
Hmm, https://deploy-preview-2452--vuejs.netlify.com/v2/examples/ looks ok at least. |
|
@garethx no, we have Hexo where menu is not generated automatically so it should be fine, I will check manually just in case |
|
@garethx sorry for the delay, just finished a review! Thank you so much for your work, I will go ahead and merge it to master to test if sandboxes are generated properly |
NataliaTepluhina
approved these changes
Jan 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@NataliaTepluhina Per my DM, this PR begins to implement the idea of transitioning external code examples to the examples folder to reduce the bus-factor and improve maintainability. These then use CodeSandbox's 'Import from GitHub' feature to load the examples, so people can experiment with the code and running version of the app, while the underlying code for them is in a place anyone can access and edit.
One question about using the examples folder and https://vuejs.org/v2/examples/ - do you know if having folders inside the examples folder will cause issues with the menu of examples on the examples page?