Skip to content

Fix Style Guide: Base component names example #2449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 22, 2020

Conversation

hzchirs
Copy link
Contributor

@hzchirs hzchirs commented Jan 20, 2020

Webpack require.context matches file relative path.
For example: ['./BaseXXX.vue', './BaseYYY.vue'], the path starts with './'
regex /^Base/ will get empty result.

Webpack `require.context` matches file relative path.
For example: `['./BaseXXX.vue', './BaseYYY.vue']`, the path starts with './'
regex `/^Base/` will get empty result.
Copy link
Member

@NataliaTepluhina NataliaTepluhina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this fix! 👍

@NataliaTepluhina NataliaTepluhina merged commit 5679c54 into vuejs:master Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants