Skip to content

fixed spanish language typo in dropdown menu #2436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 5, 2020
Merged

fixed spanish language typo in dropdown menu #2436

merged 1 commit into from
Jan 5, 2020

Conversation

Yilber
Copy link
Contributor

@Yilber Yilber commented Jan 5, 2020

español > Español

NataliaTepluhina
NataliaTepluhina approved these changes Jan 5, 2020
View reviewed changes
Copy link
Member

@NataliaTepluhina NataliaTepluhina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! 🇪🇸

@NataliaTepluhina NataliaTepluhina merged commit b51080c into vuejs:master Jan 5, 2020
@Yilber Yilber deleted the patch-1 branch January 5, 2020 19:29
@Yilber
Copy link
Contributor Author

Yilber commented Jan 5, 2020

@NataliaTepluhina You're welcome!

@phanan
Copy link
Member

phanan commented Jan 6, 2020

Hmm? AFAIK you don't capitalize language names in Spanish. For example, this is from Google's setting page:

image

@Yilber
Copy link
Contributor Author

Yilber commented Jan 6, 2020 •
edited
Loading

Hi @phanan,
The rule says that language's name belongs to the common names category, therefore, you should not capitalize ingles, frances etc. The problem is that the rule does not tell you what to do when you are listing those names. The common approach is to capitalize the first letter when you are making a list.

You can also find the following on google too if you go to language setting on the account's page

image

@Yilber
Copy link
Contributor Author

Yilber commented Jan 6, 2020

@phanan I got in touch with the RAE. I will keep you updated once they provide any feedback on this subject.

@Yilber
Copy link
Contributor Author

Yilber commented Jan 14, 2020

@phanan, @NataliaTepluhina here is the response from the RAE about the language names in dropdown menus. https://twitter.com/RAEinforma/status/1217013057118986240

It seems that Google made a small mistake.

@phanan
Copy link
Member

phanan commented Jan 14, 2020

TIL, thanks @Yilber!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NataliaTepluhina NataliaTepluhina NataliaTepluhina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Yilber @phanan @NataliaTepluhina