Skip to content

Add Spanish language to dropdown #2353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2019

Conversation

Vergara92
Copy link
Contributor

No description provided.

@phanan
Copy link
Member

phanan commented Oct 18, 2019

Isn't this a duplicate of #2212?

@alphacentauri82
Copy link
Contributor

@posva creo que este le va mucho mejor. Directo al punto

@posva
Copy link
Member

posva commented Oct 18, 2019

@alphacentauri82 estoy de acuerdo, pero por si acaso la otra persona le importa que su contribución aparezca, prefiero preguntar y esperar aunque sea un día ya que no cambiara nada para el resto de mortales pero tal vez a la persona le haga ilusión

@phanan This one is ready to merge, I commented on the other one to see if the person can do the changes so we merge the other person's pr as they were there first if they can. It's up to you to decide how much to wait or not to wait at all!

@Vergara92
Copy link
Contributor Author

@posva pues tienes toda la razón con lo de la contribución, si hace los cambios hacéis merge del suyo y canceláis este :)

thanks for all the comments!

@Vergara92
Copy link
Contributor Author

Maybe can we make this merge now? Or do you want to wait a little more? @posva @alphacentauri82 @phanan

@phanan phanan merged commit 1c55e50 into vuejs:master Oct 21, 2019
@phanan
Copy link
Member

phanan commented Oct 21, 2019

Alrighty, thanks!

@vue-bot
Copy link
Contributor

vue-bot commented Oct 21, 2019

Thanks again! 💚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants