Enforcing rel="noopener" for external _blank targets`
#2348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Not sure how we missed these in a couple of PRs before.
I believe so. Do you want to work on such a PR? |
|
Thanks again! 💚 |
|
@phanan I would love to. So |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the MDN note for for information about the privacy and security concerns.
This PR is trying to add the
rel="noopener"in the following locations:I also notice
rel="noopener noreferrer"(as a workaround for old browsers) andrel="noopener"are used at the same time across the codebase. Should we make them more consistent?