Skip to content

Correctly nest sub-menu for h3s inside h2 list item #2345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 15, 2019

Conversation

michapietsch
Copy link
Contributor

Observed behavior:
An ul with H3 links is nested inside the parent ul and as a sibling to the li containing the link to the H2.

Fix:
The sub-menu for H3s is now nested in the same way H2 sub-menu already are.

The former incorrect nesting also constitutes an a11y issue.

@phanan
Copy link
Member

phanan commented Oct 15, 2019

Thanks for the effort! Can you guide us to an example of this change in action? A before/after comparison would be even better!

@michapietsch
Copy link
Contributor Author

Yeah, sure!

Before:

Bildschirmfoto 2019-10-15 um 11 11 08

For the third level heading "Relation to Custom Elements" the containing ul is a direct child of the parent ul.

After:

Bildschirmfoto 2019-10-15 um 11 12 30

Now the li contains the a as well as the sub menu ul. For sub-menus for second level headings like "Introduction" this is already handled correctly, as you can see at the top edge of the DevTools DOM tree visualization.

Hope that helps! Please let me know, if you have any more questions!

@phanan phanan merged commit bd9ef5a into vuejs:master Oct 15, 2019
@phanan
Copy link
Member

phanan commented Oct 15, 2019

Right, thanks for the fix!

@vue-bot
Copy link
Contributor

vue-bot commented Oct 15, 2019

Thanks again! 💚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants