Globally register components example #1959
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… if you wanted to include subfolders. This solution has been tested and confirmed. https://stackoverflow.com/questions/53676837/registering-components-globally-in-vuejs-in-subfolders/53678945#53678945
…etting subfolder to true
|
Simplified the changes to address the concerns of @chrisvfritz in #1941 while still providing a solution that will work if someone has base components within subfolders of /components. |
|
Pinging @chrisvfritz. |
phanan
requested review from
chrisvfritz and
sdras
and removed request for
sdras
|
I agree this is an improvement. If Chris disagrees we can always revert :) |
phanan
pushed a commit
to phanan-forks/vuejs.org
that referenced
this pull request
Mar 14, 2019
* Automatic Global Registration of Base Components example did not work if you wanted to include subfolders. This solution has been tested and confirmed. https://stackoverflow.com/questions/53676837/registering-components-globally-in-vuejs-in-subfolders/53678945#53678945 * Updated regex in global compnent registration code example to allow setting subfolder to true
phanan
pushed a commit
to phanan-forks/vuejs.org
that referenced
this pull request
Mar 20, 2019
* Automatic Global Registration of Base Components example did not work if you wanted to include subfolders. This solution has been tested and confirmed. https://stackoverflow.com/questions/53676837/registering-components-globally-in-vuejs-in-subfolders/53678945#53678945 * Updated regex in global compnent registration code example to allow setting subfolder to true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated regex in global component registration code example to allow setting subfolder to true