Skip to content

Fix #1802; Update docs to avoid misconceptions around emitting events #1838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 27, 2019

Conversation

shentao
Copy link
Member

@shentao shentao commented Oct 12, 2018

No description provided.

@shentao shentao requested review from sdras and chrisvfritz October 12, 2018 14:52
Copy link
Member

@sdras sdras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is much better. But I wonder if we should take it a step further (not within this PR). What if I made a little animation for this? Kind of like the two videos here: https://css-tricks.com/understanding-the-almighty-reducer/

There's something about not being able to see the replacement happening and instead reading sequentially that I think is causing a cognitive overload. What do you both think?

I do approve this PR though, and think it's a great step. Curious what Chris thinks here too.

@shentao
Copy link
Member Author

shentao commented Oct 19, 2018

I think that having a diagram (possibly animated) similar to the Vuex diagram could be very helpful, especially if we can show some code snippets on top of it and visualize how everything connects.
For example, how adding @event-name sets a listener on a child instance that will be triggered when the child calls $emit.

Copy link
Member

@phanan phanan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@phanan phanan merged commit d58df8c into master Jan 27, 2019
@LinusBorg LinusBorg deleted the update-events-docs branch February 26, 2019 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants