add style guide blockquote in v-if with v-for #1794
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phanan
requested changes
Sep 16, 2018
src/v2/guide/conditional.md
Outdated
| @@ -196,4 +196,6 @@ Generally speaking, `v-if` has higher toggle costs while `v-show` has higher ini | |||
|
|
|||
| ## `v-if` with `v-for` | |||
|
|
|||
| > Use v-if and v-for together is **not recommended**. See the style guide for futher infomation [Avoid v-if with v-for](https://vuejs.org/v2/style-guide/#Avoid-v-if-with-v-for-essential) | |||
There was a problem hiding this comment.
I'd suggest something like this instead:
> Use v-if and v-for together is **not recommended**. See the [style guide](/v2/style-guide/#Avoid-v-if-with-v-for-essential) for further information.Notice the wording changes and the two spelling mistake corrections.
There was a problem hiding this comment.
thanks for your change and correcting, your version is much better.
phanan
approved these changes
Sep 19, 2018
phanan
requested changes
Sep 19, 2018
|
sorry for didn't get your point, and I push a new commit use p.tip instead. |
|
does anybody here? |
phanan
requested changes
Sep 27, 2018
|
@CeceWall Thanks for the ping. One extra little change and I think we're good to go :) |
|
thanks, and i have finished that |
phanan
requested changes
Sep 27, 2018
src/v2/guide/conditional.md
Outdated
| @@ -196,4 +196,6 @@ Generally speaking, `v-if` has higher toggle costs while `v-show` has higher ini | |||
|
|
|||
| ## `v-if` with `v-for` | |||
|
|
|||
| <p class="tip">Use `v-if` and `v-for` together is **not recommended**. See the [style guide](/v2/style-guide/#Avoid-v-if-with-v-for-essential) for further information.</p> | |||
There was a problem hiding this comment.
Sorry, but I miss this earlier 😅: It's "Using," not "Use."
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in the vue style guide, it's an essential rule to avoid use v-if and v-for together, i thought beginners should know this.