Update Instance in Guide to mention Object.freeze #1323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apologies for the formatting changes, prettier has some opinions on those js code block spaces :) |
yyx990803
reviewed
Dec 19, 2017
src/v2/guide/instance.md
Outdated
| new Vue({ | ||
| data: { | ||
| a: 1 | ||
| }, | ||
| created: function () { | ||
| created: function() { |
There was a problem hiding this comment.
it'd be great to revert the stylistic changes just for consistency
|
LGTM once we remove the two small stylistic changes 👍 |
|
Wow, you're speedy Chris, I was just fixing that up. Thanks! |
|
I'm speedy in spurts. 😅 Today is a heavy open source day for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR clarifies that Object.freeze keeps Vue's reactivity system from updating properties, as per #1319 and #978. Open to suggestions for placement in guide. Also, as per conversation in chat, adding in
yarn.lock