Skip to content

Add Props and Events Diagram #1310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 19, 2017
Merged

Add Props and Events Diagram #1310

merged 1 commit into from
Dec 19, 2017

Conversation

MatheusRich
Copy link
Contributor

I was helping with the pt-BR translation of Vue.js when I noticed that there's no .ai file of this diagram (image bellow) in the assets directory.

So, I tried to remake (as close as I could) the diagram. Here's what I've got. I hope this helps others translations around the world.

Original

My Version

@sdras
Copy link
Member

sdras commented Dec 6, 2017

That font is wrong but I'm probably the only one who will notice :)

@chrisvfritz can you tell?

@MatheusRich
Copy link
Contributor Author

MatheusRich commented Dec 6, 2017

@sdras I've noticed that too, but I don't know which one is...

@sdras
Copy link
Member

sdras commented Dec 6, 2017

Looks like Source Sans Pro to me but I could be wrong.

@chrisvfritz
Copy link
Contributor

chrisvfritz commented Dec 6, 2017

@MatheusRich I love it! 😍 I didn't notice the font (at least when out of context), but if it stood out to you @sdras, I think it'll stand out to a lot of other other people with a similar typography spideysense. 🙂 If it doesn't turn out to be Source Sans Pro, I can find out what it is.

@MatheusRich
Copy link
Contributor Author

I got the font from another diagram (state.ai i think), so maybe in some other we can find the right one.

@chrisvfritz
Copy link
Contributor

@MatheusRich Let me know if you can't find it by digging around in the other .ai files - if it's not in there, I'll launch a formal investigation. 😄

@yyx990803
Copy link
Member

yyx990803 commented Dec 19, 2017

I actually like the new font - it looks fairly close to another font used across the diagrams (Montserrat Bold). Or maybe it is already. If not, we can use Montserrat for consistency.

@chrisvfritz chrisvfritz merged commit 09c2c65 into vuejs:master Dec 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants