Skip to content

Fix header link #1280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 23, 2017
Merged

Fix header link #1280

merged 1 commit into from
Nov 23, 2017

Conversation

Justineo
Copy link
Member

@Justineo Justineo commented Nov 15, 2017 •
edited
Loading

Should convert NodeList to Array to prevent #1273.

@Justineo Justineo mentioned this pull request Nov 15, 2017
Merged
@Justineo
Copy link
Member Author

See it in action at CN site. It should work well now.

/ping @chrisvfritz

@chrisvfritz chrisvfritz merged commit 68e3ff2 into vuejs:master Nov 23, 2017
@Justineo Justineo deleted the fix-header-link branch November 23, 2017 15:23
kazupon pushed a commit to kazupon/vuejs.org that referenced this pull request Nov 24, 2017
@vuejs-jp-bot @kazupon
fix header link, convert NodeList to Array to prevent vuejs#1273 (vue…
a42424a 
…js#1280) (vuejs#476)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Justineo @chrisvfritz