[Doc EN]: remove Single-file component top-level element order from style-guide/index.md
#1275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bruno Lesieur <bruno.lesieur@gmail.com>
Signed-off-by: Bruno Lesieur <bruno.lesieur@gmail.com>
Signed-off-by: Bruno Lesieur <bruno.lesieur@gmail.com>
|
@chrisvfritz, I'm not sure you watch closed issue (and it's normal) so I highlight you an answer I do about an additional thing in Styleguide about What do you think about this? Useful? True? |
|
Thanks! I think I miscommunicated though. 😅 I actually meant only remove the part that dictates a specific order. I still want to keep the rule suggesting a consistent order within the project, because I still think consistency is helpful. Does that make sense? |
|
Also, thanks for the ping about that closed issue. I'll take a closer look and give feedback. |
|
Absolutely! And I prefer just reorder it like I initially suggest! Cool! I
will change this PR!
Le 12 nov. 2017 02:43, "Chris Fritz" <notifications@github.com> a écrit :
… Also, thanks for the ping about that closed issue. I'll take a closer look
and give feedback.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1275 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ADs8uXf28VaXIFacEjuKTCjpBCBrV4tCks5s1k00gaJpZM4Qajkx>
.
|
Signed-off-by: Bruno Lesieur <bruno.lesieur@gmail.com>
# Conflicts: # src/v2/style-guide/index.md Signed-off-by: Bruno Lesieur <bruno.lesieur@gmail.com>
….org into styleguide-update # Conflicts: # src/v2/style-guide/index.md Signed-off-by: Bruno Lesieur <bruno.lesieur@gmail.com>
|
Ok @chrisvfritz, it done ;) Just need your through about: #1245 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed below with @chrisvfritz, we removed this part which really depends on prefered usage of
.vuefile.— #1246 (comment)