Skip to content

Add Vietnamese option to language dropdown #1244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2017

Conversation

phainv
Copy link
Contributor

@phainv phainv commented Oct 31, 2017

First of all, Thanks for having the document suport Vietnamese. Link Repo
But. It does not display in the language selection. might it not yet perfected (beta version). But it is essential to understand it.
Thanks!

@chrisvfritz
Copy link
Contributor

@phanan I'll leave this up to you. Merge if you think it's a good idea.

@chrisvfritz chrisvfritz requested a review from phanan November 3, 2017 18:28
@phanan phanan merged commit 91a2705 into vuejs:master Nov 3, 2017
@phanan
Copy link
Member

phanan commented Nov 3, 2017

Thanks both! Merged.
@phainv Would you mind creating a similar PR in the Vietnamese repo as well?

@phanan
Copy link
Member

phanan commented Nov 4, 2017

Actually scratch that – we don't need a new menu item in Vi version.

@phainv
Copy link
Contributor Author

phainv commented Nov 4, 2017

@phanan I thought so. Because by default its language is set to Vietnamese

@phainv phainv deleted the language_dropdown branch November 5, 2017 07:04
kazupon pushed a commit to kazupon/vuejs.org that referenced this pull request Nov 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants