Skip to content

Clarify how to define filters #1225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 3, 2017
Merged

Clarify how to define filters #1225

merged 2 commits into from
Nov 3, 2017

Conversation

flybayer
Copy link
Contributor

I was confused about how to do this, as are others.

@matthew-kerle
Copy link

Thanks for taking the time to submit a PR to update these docs. Since it had new Vue({... at the top, it was misleading and I tried to register as part of the main Vue instance as well.

@chrisvfritz
Copy link
Contributor

Thanks! I made a few tweaks, particularly so that the component example is not specific to a single-file component or specific module system, but this is a great change. 🙂

@chrisvfritz chrisvfritz merged commit 3b3b9b5 into vuejs:master Nov 3, 2017
@flybayer flybayer deleted the patch-1 branch November 3, 2017 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants