Fix: Demystified markdown logic #1186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have changes jsfiddle link with a similar jsfiddle. The difference between two jsfiddle is in javascript code, `marked()` has a comment mentioning its source as external library. This is important because it is easy to assume that `marked()` cmes from an external library instead of Vue, especially for a beginner.
|
Good idea! I made a slight modification: added the dependencies to the HTML, so that it would be more apparent that we're using external libraries here. |
phanan
added a commit
to vuejs-vn/vuejs.org
that referenced
this pull request
Oct 10, 2017
* Replace `true` with truthy (vuejs#1196) * Change "Registration" to "Global Registration" (vuejs#1192) * typos (vuejs#1191) * [Website]: Let menu to be above add (vuejs#1188) Signed-off-by: Bruno Lesieur <bruno.lesieur@gmail.com> * Fix: Demystified markdown logic (vuejs#1186) * Fix: Demystified markdown logic I have changes jsfiddle link with a similar jsfiddle. The difference between two jsfiddle is in javascript code, `marked()` has a comment mentioning its source as external library. This is important because it is easy to assume that `marked()` cmes from an external library instead of Vue, especially for a beginner. * make dependencies apparent in markdown example * Correct the heading tags (vuejs#1181) correct the opening and closing `h4` tags * Make the statement less definitive (vuejs#1190) * Make the statement less definitive * Reword the tip * add SG exception where kebab-case everywhere is also acceptable for components in templates * revise single-file components, with new example sandbox * Add Additional Resources to ecosystem dropdown (vuejs#1182) * Add additional resources to dropdown * reorganize ecosystem dropdown, adding Tooling * Move roadmap to News section of ecosystem dropdown * Update "Core Plugins" to "Core Libraries" * rename SG complex expressions rule to simple * rename SG complex computed expressions rule to simple * address SG question about coupled component names, fixes vuejs#1195 * fix SG typos, fixes vuejs#1194 * make it more obvious in SG that details can be expanded, fixes vuejs#1170 * Update custom-directive.md (vuejs#1198) I suggest add this params demo because i can not understand when i saw this part,i think other people will have the same confusion * clarified titles of SG priority D rules * Re-translate the arrow function tip
kazupon
pushed a commit
to kazupon/vuejs.org
that referenced
this pull request
Nov 24, 2017
* Fix: Demystified markdown logic I have changes jsfiddle link with a similar jsfiddle. The difference between two jsfiddle is in javascript code, `marked()` has a comment mentioning its source as external library. This is important because it is easy to assume that `marked()` cmes from an external library instead of Vue, especially for a beginner. * make dependencies apparent in markdown example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have changes jsfiddle link with a similar jsfiddle.
The difference between two jsfiddle is in javascript code,
marked()has a comment mentioning its source as external library.This is important because it is easy to overlook that
marked()comes from an external library instead of Vue, especially for a beginner.