Skip to content

Add custom filter function syntax explanation #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Add custom filter function syntax explanation #117

wants to merge 2 commits into from

Conversation

StoyanDimitrov
Copy link

No description provided.

@StoyanDimitrov StoyanDimitrov changed the title Enhance custom filter function sintax Add custom filter function syntax explanation Sep 7, 2015
@@ -139,6 +139,7 @@ Or, just pass in a custom filter function:
``` html
<div v-repeat="user in users | filterBy myCustomFilterFunction">
```
Where [myCustomFilterFunction] is regular [vm] method accepting three arguments [user], [index] and [users] from the example above.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use backticks "`" instead of square brackets here?

Square brackets changed to backticks to match the document style
@@ -139,6 +139,7 @@ Or, just pass in a custom filter function:
``` html
<div v-repeat="user in users | filterBy myCustomFilterFunction">
```
Where `myCustomFilterFunction` is regular `vm` method accepting three arguments `user`, `index` and `users` from the example above.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It probably make more sense to point out here that the method is expected to be a function that you'd pass to Array.prototype.filter.

@yyx990803
Copy link
Member

This PR is no longer relevant for the 1.0 docs - feel free to re-submit against 0.12 branch.

@yyx990803 yyx990803 closed this Oct 20, 2015
@StoyanDimitrov StoyanDimitrov deleted the patch-1 branch November 2, 2015 16:14
kazupon pushed a commit to kazupon/vuejs.org that referenced this pull request Oct 2, 2016
dingyiming added a commit that referenced this pull request Dec 21, 2016
modify some format problems in guide migration
lex111 pushed a commit to lex111/vuejs.org that referenced this pull request Feb 3, 2018
- Правки по свежим коммитам
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants