Skip to content

Change recommended links to jsDelivr #1134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 21, 2017
Merged

Conversation

LukasDrgon
Copy link
Contributor

jsDelivr is the fastest opensource cdn available and can now serve any project from npm with zero config. This PR changes the links from unpkg back to jsDelivr. vuejs/vue#6618 should be merged first to make sure that the short links work correctly.

@chrisvfritz
Copy link
Contributor

@LukasDrgon I'm OK with this. We've had nothing but good experiences with jsDelivr and some community members have mentioned that it's even faster in their part of the world. Some requests however:

  • I notice we're using both .net and .com throughout our links. Let's standardize on .com.
  • Let's always use the shortest version of the link possible. For example, https://www.jsdelivr.com/npm/vue/ instead of https://www.jsdelivr.com/package/npm/vue/.
  • Let's still mention unkpg.com as one of the options, similar to cdnjs.
  • Let's maintain the existing formatting. For example, there's a missing space after Recommended:.

@LukasDrgon
Copy link
Contributor Author

@chrisvfritz I fixed the formatting and added unpkg as an alternative.

Regarding .com vs .net - .net is the CDN and .com is the website (that's also the reason why there's /package/ in one link). I could replace the link to https://www.jsdelivr.com/package/npm/vue with https://cdn.jsdelivr.net/npm/vue/ if you want, but it's a different page with different content, so let me know which one you prefer.

@chrisvfritz
Copy link
Contributor

Ah, thanks for the explanation! I feel like it's easier to remember to just add an ending slash to https://cdn.jsdelivr.net/npm/vue, so let's go with that one. After that, this is looking good to merge as soon as vuejs/vue#6618 is. 👍

@chrisvfritz chrisvfritz merged commit 6a5b011 into vuejs:master Sep 21, 2017
chrisvfritz pushed a commit that referenced this pull request Sep 27, 2017
* Change recommended links to jsDelivr

* Replace cdn links in other files

* Fix formatting and add unpkg

* Change a link from .com to .net
kazupon pushed a commit to kazupon/vuejs.org that referenced this pull request Nov 24, 2017
* Change recommended links to jsDelivr (vuejs#1134)

* Update date

* Fix standalone vue.js cdn url (vuejs#1146)

The other one results in `vue.common.js:245 Uncaught ReferenceError: process is not defined` while loading

* Revert updated date
@LukasDrgon LukasDrgon deleted the patch-1 branch December 5, 2017 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants