Update #860
Merged
Update #860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unnecessary escape character: \-
Otherwise, VNode is used without definition the first time you encounter it in the Guide. Fixes #1799.
So they don't require horizontal scrolling
* Unify examples HTML formatting * Unify examples HTML formatting
* docs: Add Ben Hong to Community Partners * style: Remove new lines from autoformatting
* Adds Code Of Conduct via contributor-covenant version 1.4 * Change community email * Resolve conflict
[List Rendering](https://vuejs.org/v2/guide/list.html#key) guide doesn't mention what types of values user can supply for `key` of `v-for`. There is a console warning for this already but it's hard to point people to it. This pull request fixes the issue.
`$attrs` and `$listeners` were introduced in v2.4.0. The docs should mention this in order to avoid confusion.
* Add Vuejs Amsterdam * fix profiles for vue.js amsterdam organizers
* Update dockerize cookbook Node 9 has been EOL for a while, this will make sure people will always use the latest LTS version, instead of a hardcoded version number * Update dockerize-vuejs-app.md
The link to the live demo is not up-to-date. I've updated it to the same one as noted in [vue-hackernews-2.0](https://github.com/vuejs/vue-hackernews-2.0/blob/master/README.md)
This commit fixes broken instructions on how to bundle the Runtime + Compiler with Rollup. Related: rollup/rollup#2609
The example of using async_function syntax is wrong, fix it.
Removing Vuetron as the project is no longer active.
In continuation to this PR vuejs/v2.vuejs.org#1933
* Clarify that "slot-scope" is named "scope" before 2.5.0 * Improve wording
Fixes [#1765](vuejs/v2.vuejs.org#1765). I left the "define custom key modifier aliases" section at the bottom, below the deprecated key codes information. Definitely open to changing / re-arranging as needed!
* vuejs-templates/* is deprecated because of Vue CLI 3 * vue-touch has been depreceated because of lack of development
Added myself as a community partner 
|
Also, some of the images in
@yyx990803 you may need to have a check because it's sponsors related. Thanks. |
Justineo
requested changes
Jan 30, 2019
Co-Authored-By: Jinjiang <zhaojinjiang@me.com>
Co-Authored-By: Jinjiang <zhaojinjiang@me.com>
Co-Authored-By: Jinjiang <zhaojinjiang@me.com>
Co-Authored-By: Jinjiang <zhaojinjiang@me.com>
Memo: these two things above have already been orally agreed by @yyx990803. So merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: vuejs/v2.vuejs.org@242dea4...1a73684
except for:
Update Key Modifiers to suggest KeyboardEvent.key v2.vuejs.org#1850 (comment)
Thanks.