-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Update render-function.md #629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
此处翻译的binding我感觉应该是传进钩子函数的参数binding,不应该翻译成汉语。而oldValue则是binding的oldValue属性,同样不能翻译成汉语。
Justineo
reviewed
Dec 24, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我认为这个修改是合理的,不过建议先对原文增加反引号标记,中文版再同步此改动。
oldValue 是明显的需要反引号标记的,我直接改掉好了,同时对语序做了小调整。 |
@Jinjiang |
原文项目的 PR 合入了再合这个吧。 |
@Justineo 好的! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
此处翻译的binding我感觉应该是传进钩子函数的参数binding,不应该翻译成汉语。而oldValue则是binding的oldValue属性,同样不能翻译成汉语。