Skip to content

Update render-function.md #629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 24, 2017
Merged

Update render-function.md #629

merged 2 commits into from
Dec 24, 2017

Conversation

wangyi7099
Copy link
Contributor

此处翻译的binding我感觉应该是传进钩子函数的参数binding,不应该翻译成汉语。而oldValue则是binding的oldValue属性,同样不能翻译成汉语。

此处翻译的binding我感觉应该是传进钩子函数的参数binding,不应该翻译成汉语。而oldValue则是binding的oldValue属性,同样不能翻译成汉语。
@wangyi7099
Copy link
Contributor Author

wangyi7099 commented Dec 24, 2017

详情请见这张传进钩子函数的参数的截图:

上图的第二个参数就是传进来的binding参数。

Copy link
Member

@Justineo Justineo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我认为这个修改是合理的,不过建议先对原文增加反引号标记,中文版再同步此改动。

@Jinjiang Jinjiang merged commit 6e81d2d into vuejs:master Dec 24, 2017
@Jinjiang
Copy link
Member

oldValue 是明显的需要反引号标记的,我直接改掉好了,同时对语序做了小调整。
binding 我建议可以在英文仓库先简单讨论一下,达成一致之后再同步过来也不迟。
谢谢🙏

@wangyi7099
Copy link
Contributor Author

@Jinjiang @Justineo
貌似发了issus没人理 只能等到有人回复的时候再讨论了。

@Jinjiang
Copy link
Member

Jinjiang commented Dec 25, 2017 via email

@wangyi7099
Copy link
Contributor Author

@Jinjiang
= = 额 人家给出答案了, 貌似binding这个参数的意思 = = !

@wangyi7099
Copy link
Contributor Author

@Jinjiang @Justineo
两位大佬能否改一下? binding代表了binding这一参数,英文站已经给出了答案了。

@Justineo
Copy link
Member

@wangyi7099 #633

原文项目的 PR 合入了再合这个吧。

@wangyi7099
Copy link
Contributor Author

@Justineo 好的!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants