English pr 817 #280
Merged
English pr 817 #280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry，http://vuejs.org/v2/guide/migration-vue-router.html 这里没找到原文的位置，可以确定一下你翻译的对应的原文吗？ |
|
英文版的还没被 merge 进去，一开始打算直接加 watcher，posva 认为 $route 对象应该是只读的，不同意加 watcher 并在其中修改 $route，因此修改了一下，目前还没反馈。 来源是有人在 segmentfault 提了一个问题：最新版vue-router的bug，然后我在 vue-router 提了一个 issue，经证实是 V2 对 V1 的一个 breaking change，如果再改回去又会形成一个新的 breaking change，因此我觉得接受改变可能更好，并在 升迁向导 里加了个说明。 遇到这方面问题的可能不多，因此 勾股大侠 可以不着急 merge，等英文版那边定稿后我还可能会再提交修改。 THX |
|
明白了，我这边先做个 issue 关联 |
|
@Jinjiang 勾股大神，英文版 prova 已修改并审核通过，中文版和英文版代码格式略有不同，此外，中文版中加了使用 watcher 的方式，个人认为，在确信该 query 是数组时，添加 watcher 才是一劳永逸的最佳实践，因此夹点私货 （手动 doge PS: 在由于 url 语法 breaking change 导致数组数据类型破坏的 query 中，query 的“原始性”是个伪命题 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.