Document gotcha with :is and DOM props #1955
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oohira
reviewed
Dec 7, 2019
src/v2/guide/components.md
Outdated
Comment on lines
607
to
609
| この属性は通常の HTML 要素にも使えますが、コンポーネントとして取り扱われることに注意してください。 | ||
| つまり、全ての属性が ** DOM の属性としてバインドされる** ということになります。 | ||
| `value` などの一部のプロパティが、期待通りに動作するためには、[`.prop` 修飾子](../api/#v-bind) を使ってバインドする必要があります。 |
There was a problem hiding this comment.
nits: 細かいですが、原文では1段落なので合わせていただいてもよいでしょうか？
There was a problem hiding this comment.
レビューありがとうございます！後ほど対応いたします！
|
@oohira 修正させていただきました！ |
oohira
approved these changes
Dec 10, 2019
|
@inosy22 LGTM. ありがとうございました！ 👍 |
|
Hey @inosy22, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚 |
|
ご確認ありがとうございました！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
resolve #1947
補足
こちらのコミットの翻訳になります。
vuejs/v2.vuejs.org@3d96b74
レビューよろしくお願いいたします🙏