Skip to content

#598 Ignore templates with src tag in no-unused-components #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 20, 2018
Merged

#598 Ignore templates with src tag in no-unused-components #607

merged 1 commit into from
Oct 20, 2018

Conversation

armano2
Copy link
Contributor

@armano2 armano2 commented Oct 13, 2018 •
edited
Loading

fix issue: #598

@armano2
Copy link
Contributor Author

armano2 commented Oct 13, 2018

i'm unsure if this is valid way to handle this, we could add reading "src" in parser, but its risky (can cause alot of issues if files are generated dynamicly, or processed/generated by scripts)

mysticatea
mysticatea approved these changes Oct 20, 2018
View reviewed changes
Copy link
Member

@mysticatea mysticatea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR!

LGTM. I think this is the right way.

@mysticatea mysticatea merged commit dd6ed4f into vuejs:master Oct 20, 2018
@armano2 armano2 deleted the 598-no-unused-components branch October 20, 2018 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mysticatea mysticatea mysticatea approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@armano2 @mysticatea