Skip to content

Improve warning wording in vue/no-v-for-template-key docs #1858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 22, 2022

Conversation

yammyxing
Copy link
Contributor

fix the warning note on rule conflicts between vue/no-v-for-template-key and vue/no-v-for-template-key-on-child

fix the warning note on rule conflicts between  vue/no-v-for-template-key and vue/no-v-for-template-key-on-child
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the original note is correct.
However, I am not familiar with English, so I may have misunderstood.
Could you give me the details on this fix?

Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @ota-meshi, the previous note was correct. But it was difficult to understand, so here is my approach to clear that up. See also the similar #1859 (comment)

@yammyxing
Copy link
Contributor Author

ok, the approach is clear enough.

@yammyxing
Copy link
Contributor Author

I think the original note is correct. However, I am not familiar with English, so I may have misunderstood. Could you give me the details on this fix?

seems like i get the meaning of 'use with' wrong, my bad [Lol]

@FloEdelmann FloEdelmann changed the title docs: fix the warning note Improve warning wording in vue/no-v-for-template-key docs Apr 22, 2022
@FloEdelmann FloEdelmann merged commit 849e969 into vuejs:master Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants