Rename and add options to this-in-template.

[armano2]

fixes #148

[mysticatea]

Thank you very much!

Almost looks good to me, but I have some concerns.
Could you take a look?

[mysticatea]

I think that it should check whether variables which have the same name as the property name.

<template>
    <div v-for="x of xs">
        {{this.x}} <!-- we cannot remove this `this.`. -->
    </div>
</template>

Also, I think that it should check whether the this is MemberExpression#object.

<template>
    <child :parent="this" /> <!-- we cannot remove this `this`. -->
</template>

[mysticatea]

Incidentally, I have improved vue-eslint-parser as having the relationship between variables and references: vuejs/vue-eslint-parser@02579df.

• Variable#references is an array of references which use the variable. If this is empty, it's an unused variable.
• Reference#variable is the variable that the reference uses. If this is null, it's global variable or the member of the instance or undefined.

Though, I'm not sure that it helps this rule.

[armano2]

@mysticatea i i like changes with references it can simplify this rule and no-template-shadow

but for now there is infinite loop there: vuejs/vue-eslint-parser#16
https://gist.github.com/armano2/c34068d62fdb190a37e1a43ad0f88faf

---

suggestions applied

[mysticatea]

Thank you!

I'm sorry, I have realized one more thing. If property name is a reserved word (e.g. this.class), we cannot remove the this. since it causes syntax errors. Could you add the check into "never"?

[armano2]

@mysticatea check for js reserved names added

[armano2]

additionality i added support for this['0aaaa'] and this['foo-bar bas'] which should not be warned

[armano2]

@mysticatea with latest change to parser, reference variables are no longer there

Sent from my Xiaomi Redmi 4A using FastHub

[mysticatea]

I'm sorry for late.

additionality i added support for this['0aaaa'] and this['foo-bar bas'] which should not be warned

Good catch!

with latest change to parser, reference variables are no longer there

I think, in fact, console.log() no longer shows Variable#references and Reference#variable since those are non-enumerable properties. But those are still there. Tests exist at vue-eslint-parser/test/variables-references.js#L152-L248.

[michalsnik]

GJ! I'll release it at the end of this weekend @mysticatea @armano2 . I'm moving to new place, so have quite a lot on my plate lately..