Skip to content

Supports ESLint v7.x #1077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 9, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ workflows:
- node-v8
- node-v10
- node-v12
- node-v14

version: 2
jobs:
Expand All @@ -31,9 +32,23 @@ jobs:
command: npm test

node-v8:
<<: *node-base
docker:
- image: node:8
steps:
- run:
name: Versions
command: npm version
- checkout
- run:
name: Install eslint@6
command: |
npm install -D eslint@6.0.0
- run:
name: Install dependencies
command: npm install
- run:
name: Test
command: npm test
node-v10:
<<: *node-base
docker:
Expand All @@ -42,3 +57,7 @@ jobs:
<<: *node-base
docker:
- image: node:12
node-v14:
<<: *node-base
docker:
- image: node:14
10 changes: 5 additions & 5 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,12 @@ module.exports = {
overrides: [{
files: ['lib/rules/*.js'],
rules: {
"consistent-docs-description": "error",
"no-invalid-meta": "error",
"no-invalid-meta-docs-categories": "error",
'consistent-docs-description': 'error',
'no-invalid-meta': 'error',
'no-invalid-meta-docs-categories': 'error',
'eslint-plugin/require-meta-type': 'error',
"require-meta-docs-url": ["error", {
"pattern": `https://eslint.vuejs.org/rules/{{name}}.html`
'require-meta-docs-url': ['error', {
'pattern': `https://eslint.vuejs.org/rules/{{name}}.html`
}]
}
}]
Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
"node": ">=8.10"
},
"peerDependencies": {
"eslint": "^5.0.0 || ^6.0.0"
"eslint": "^6.0.0 || ^7.0.0"
},
"dependencies": {
"eslint-utils": "^2.0.0",
Expand All @@ -62,7 +62,7 @@
"acorn": "^7.1.0",
"babel-eslint": "^10.0.2",
"chai": "^4.1.0",
"eslint": "^6.0.0",
"eslint": "^7.0.0",
"eslint-plugin-eslint-plugin": "^2.0.1",
"eslint-plugin-import": "^2.18.2",
"eslint-plugin-vue": "file:.",
Expand Down
14 changes: 7 additions & 7 deletions tests/lib/rules/attributes-order.js
Original file line number Diff line number Diff line change
Expand Up @@ -625,23 +625,23 @@ tester.run('attributes-order', rule, {
errors: [
{
message: 'Attribute "is" should go before "v-once".',
nodeType: 'VIdentifier'
type: 'VIdentifier'
},
{
message: 'Attribute "v-on:click" should go before "v-once".',
nodeType: 'VDirectiveKey'
type: 'VDirectiveKey'
},
{
message: 'Attribute "ref" should go before "v-once".',
nodeType: 'VIdentifier'
type: 'VIdentifier'
},
{
message: 'Attribute "id" should go before "v-text".',
nodeType: 'VIdentifier'
type: 'VIdentifier'
},
{
message: 'Attribute "myProp" should go before "v-text".',
nodeType: 'VIdentifier'
type: 'VIdentifier'
}
]
},
Expand Down Expand Up @@ -683,7 +683,7 @@ tester.run('attributes-order', rule, {
errors: [
{
message: 'Attribute "v-if" should go before "class".',
nodeType: 'VIdentifier'
type: 'VDirectiveKey'
}
]
},
Expand All @@ -709,7 +709,7 @@ tester.run('attributes-order', rule, {
errors: [
{
message: 'Attribute "v-slot" should go before "v-model".',
nodeType: 'VIdentifier'
type: 'VDirectiveKey'
}
]
},
Expand Down
4 changes: 2 additions & 2 deletions tests/lib/rules/multiline-html-element-content-newline.js
Original file line number Diff line number Diff line change
Expand Up @@ -286,15 +286,15 @@ content
message: 'Expected 1 line break after opening tag (`<div>`), but no line breaks found.',
line: 5,
column: 12,
nodeType: 'HTMLTagClose',
type: 'HTMLTagClose',
endLine: 5,
endColumn: 12
},
{
message: 'Expected 1 line break before closing tag (`</div>`), but no line breaks found.',
line: 5,
column: 19,
nodeType: 'HTMLEndTagOpen',
type: 'HTMLEndTagOpen',
endLine: 5,
endColumn: 19
}
Expand Down
4 changes: 2 additions & 2 deletions tests/lib/rules/singleline-html-element-content-newline.js
Original file line number Diff line number Diff line change
Expand Up @@ -227,15 +227,15 @@ content
message: 'Expected 1 line break after opening tag (`<div>`), but no line breaks found.',
line: 3,
column: 30,
nodeType: 'HTMLTagClose',
type: 'HTMLTagClose',
endLine: 3,
endColumn: 30
},
{
message: 'Expected 1 line break before closing tag (`</div>`), but no line breaks found.',
line: 3,
column: 37,
nodeType: 'HTMLEndTagOpen',
type: 'HTMLEndTagOpen',
endLine: 3,
endColumn: 37
}
Expand Down