Skip to content

Update options-data.md #950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 5, 2021
Merged

Update options-data.md #950

merged 3 commits into from
Apr 5, 2021

Conversation

likev
Copy link
Contributor

@likev likev commented Mar 18, 2021

Description of Problem

from Vue.js 2.x you can not just watch an expression

Additional Information

vuejs/vue#844 (comment)

from Vue.js 2.x you can not just watch an expression vuejs/vue#844 (comment)
Copy link
Member

@bencodezen bencodezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about these updates?

Co-authored-by: Ben Hong <ben@bencodezen.io>
@likev
Copy link
Contributor Author

likev commented Mar 26, 2021

What do you think about these updates?

I think we can merge and close the pull

@skirtles-code
Copy link
Contributor

I personally find this wording a little difficult to follow. The 'to watch' after the second dash throws me off. I tried reading it out loud and I don't seem to be able to put the emphasis in the right place.

@bencodezen bencodezen requested a review from skirtles-code April 4, 2021 18:33
@bencodezen
Copy link
Member

@skirtles-code Good observation! What do you think of the movement of "to watch" earlier on to better separate out the concepts?

@skirtles-code
Copy link
Contributor

I like it. Merging. Thank you both.

@skirtles-code skirtles-code merged commit 90688fa into vuejs:master Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants