Skip to content

Use local copies of images rather than external URLs #914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 27, 2021

Conversation

skirtles-code
Copy link
Contributor

A handful of pages were using external URLs to pull in images. This PR adds those images to this repo and uses local URLs instead.

The motivation here is:

  1. Keep as much content as possible under source control, so it can't change unexpectedly.
  2. Avoid dependencies on other domains that could be blocked or otherwise unavailable for some users.

I have not migrated the 'coffee cup' animation.

Copy link
Member

@NataliaTepluhina NataliaTepluhina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @skirtles-code!

@NataliaTepluhina NataliaTepluhina merged commit 4b0baab into vuejs:master Feb 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants