docs: updating guidance for conditional class application #824
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Problem
The guidance for using conditional classes is a little bit misleading as the following:
'This will always apply
errorClass
, but will only applyactiveClass
whenisActive
is truthy.'Can be misinterpreted as:
'This will always apply
errorClass
, however whenisActive
is truthy, it will ONLY applyactiveClass
and nothing else.'I personally had to take time to test the code myself in order to verify the actual behaviour, which should not be a requirement for documentation readers.
Proposed Solution
I renamed the above to:
'This will always apply
errorClass
, butactiveClass
will only be applied whenisActive
is truthy.'