Skip to content

Refactor the effect on the sponsors and fix a position caching bug #815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 16, 2021
Merged

Refactor the effect on the sponsors and fix a position caching bug #815

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 15 additions & 24 deletions src/.vuepress/theme/components/Home.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@

<Content class="theme-default-content custom" />

<section class="section-sponsors" ref="sponsors">
<section class="section-sponsors" :class="{ active: sponsorsActive }" ref="sponsors">
<div class="inner">
<PatreonSponsors :sponsors="sponsors" />
<OpenCollectiveSponsors />
Expand Down Expand Up @@ -85,7 +85,8 @@ export default {
},

data: () => ({
sponsors
sponsors,
sponsorsActive: false
}),

computed: {
Expand All @@ -103,29 +104,19 @@ export default {
},

mounted() {
if (!window) {
return
}
window.addEventListener('scroll', this.onPageScroll)
},

const sponsors = this.$refs.sponsors
let sponsorTop = sponsors.offsetTop
let sponsorActive = false

window.addEventListener('resize', () => (sponsorTop = sponsors.offsetTop))

window.addEventListener('scroll', () => {
if (window.pageYOffset > sponsorTop - 100) {
if (!sponsorActive) {
sponsorActive = true
sponsors.classList.add('active')
}
} else {
if (sponsorActive) {
sponsorActive = false
sponsors.classList.remove('active')
}
}
})
beforeDestroy() {
window.removeEventListener('scroll', this.onPageScroll)
},

methods: {
onPageScroll() {
const sponsorTop = this.$refs.sponsors.offsetTop

this.sponsorsActive = window.pageYOffset > sponsorTop - 100
}
}
}
</script>
Expand Down