Skip to content

feat: add unwrap example code to reactive #814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 18, 2021

Conversation

pikax
Copy link
Member

@pikax pikax commented Jan 15, 2021

Description of Problem

No example on how the unwrapping works when assigning a ref

Proposed Solution

Add a warning since it might be a pitfall if someone is expecting to access the ref with .value when assigning to a reactive

Additional Information

This functionality might be referenced else where, but without any clear example (if I recall correctly)

Copy link
Member

@NataliaTepluhina NataliaTepluhina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pikax thank you for the addition! I've tweaked the code a bit

Co-authored-by: Natalia Tepluhina <tarya.se@gmail.com>
@NataliaTepluhina NataliaTepluhina merged commit 7f9401e into vuejs:master Jan 18, 2021
@pikax pikax deleted the add_deep_unwrap_warn branch January 20, 2021 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants