feat: add note on isCustomElement in runtime-only builds #779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The isCustomElement config option only applies when using the runtime compiler. Since most users will be using the runtime-only compiler (eg. via vue-loader or @vue/cli), we should add a note that they may need to configure vue-loader instead.
|
Hmm, I am not quite sure if it's an issue with my PR or the CI job that tags alert blocks - is it because I am not a member of the @vuejs org? |
NataliaTepluhina
approved these changes
Jan 6, 2021
There was a problem hiding this comment.
@Xenonym thank you for adding this! The CI job fails to draw attention to the added tip block - we try to avoid having too many of them, but the current one seems to be justified for me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Problem
The
isCustomElementconfig option only applies when using the runtime compiler. Since most users will be using the runtime-only compiler (eg. viavue-loaderor@vue/cli), they may attempt to configure this option by mistake (eg.vuejs/vue-next#2779).Proposed Solution
Let's add a note that they may need to configure
vue-loader'scompilerOptionsfor custom elements to work properly.Additional Information
The language used is taken from the migration guide.